Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for precompiled binary failing on Windows to CI #389
Add test for precompiled binary failing on Windows to CI #389
Changes from 2 commits
b0507f6
8e73177
db4da76
8d7d944
0d49570
381dc87
2719f07
bfe6cdb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added caching for baseline rustdoc JSON files in the other jobs -- would you mind adding it here too? You'll need to amend the top
EXPECTED
variable since right now it effectively asserts that caching isn't used (Parsing ref_slice v1.2.1 (baseline)
, not(baseline, cached)
), and add the new caching steps as in the other jobs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added caching, but also extracted building the Windows binary to a separate job as you did with the one for Ubuntu. I think it makes it a little cleaner and we don't have to manually remove the index directory if we restore the cached binary instead of building it. What is your opinion?
One may ask why I created a separate
build-binary-windows
job instead of using matrix strategy for the existing one. The main reason is that building the tool on Windows appears to be much slower, and if we use matrix strategy, there is currently no way for other jobs to depend only on the ubuntu case, which makes the whole CI last longer...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanation here is great, but once this PR merges, we probably won't remember why the jobs are separate. We might even merge them together into a matrix, even though you clearly point out how that isn't the right thing to do.
Consider adding this as a comment in the CI file, where it will be harder to miss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Added in #407