Update features heuristic to include more unstable and private feature name patterns

[era]

Addresses #461, by adding _, unstable- and unstable_ prefixes to ignore.

[obi1kenobi]

This looks good, just a couple of small nitpicks.

I've found that reading one's own code in the GitHub PR review interface makes it more likely to spot these kinds of little typos. We all get used to looking at our code changes in our local editor and the typos become invisible, so the change of scenery helps make them stand out.

I'd highly recommend trying it, since it would both increase your velocity and reduce the number of back-and-forth code review cycles before merging. I think you could have noticed all the things I pointed out in this review by yourself with one self-review like that.

[obi1kenobi]

Out of curiosity, do we need the String::from() here and above? Would this code work if these were static &str instead?

[era]

Oh, it would! I'm cleaning it to be &str instead.

[obi1kenobi]

I think this is just .any(|p| feature_name.starts_with(p)) right?

[era]

Thank you for the review, I properly setup my editor, so I should not have that type of problem anymore :).

Thank you again for all the tips,

[obi1kenobi]

@era awesome work! Are you happy staying on the CLI side for now or would you like to try your hand at writing some lints as well? It's all the same to me, so it's your call :)

The docs for writing lints are here and I think I linked to a few easy-ish lints to start with in a prior chat.

[era]

Ah, thank you for pointing me to the lint docs, I think I will try to do one lint to see how it goes! Thank you again for all mentoring around the project!!

[obi1kenobi]

No worries, thanks for all the awesome contributions — it's my pleasure to help!