Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new lint: trait_method_unsafe_removed #612

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

yottalogical
Copy link
Contributor

Adds the lint described in #606.

@obi1kenobi
Copy link
Owner

So far so good! Let me know if you have any questions.

@yottalogical yottalogical marked this pull request as ready for review December 21, 2023 18:17
@yottalogical
Copy link
Contributor Author

I'm still pretty new to Trustfall, so I mostly just copied #608 making modifications where necessary. Would you be able to look over the query and see if there's anything wrong or that could otherwise be improved?

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nicely done!

@obi1kenobi
Copy link
Owner

Would you be able to look over the query and see if there's anything wrong or that could otherwise be improved?

It was great, no notes!

Might you be interested in getting some more practice with Trustfall? There are more opportunities for writing lints (Trustfall query language practice), as well as more opportunities to expose data in the Trustfall schema which is a way to get familiarized with the rest of Trustfall's APIs.

@obi1kenobi obi1kenobi merged commit 58711ac into obi1kenobi:main Dec 21, 2023
32 checks passed
@yottalogical yottalogical deleted the trait_method_unsafe_removed branch December 21, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants