Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust 1.76 to CI explicitly, now that stable is 1.77. #713

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Add Rust 1.76 to CI explicitly, now that stable is 1.77. #713

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c8db18
Add Rust 1.76 to CI explicitly, now that stable is 1.77.
obi1kenobi Mar 21, 2024
e198f5a
Echo commands to make debugging CI job easier.
obi1kenobi Mar 21, 2024
0e85dc8
Fix variable references.
obi1kenobi Mar 21, 2024
fa06ba1
Fix variable outputs.
obi1kenobi Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ jobs:
#
# Also make sure to update the MSRV in the cargo-semver-checks-action CI:
# https://github.com/obi1kenobi/cargo-semver-checks-action/blob/main/.github/workflows/test-action.yml#L18
toolchain: ["1.74", "1.75", "stable", "beta"]
toolchain: ["1.74", "1.75", "1.76", "stable", "beta"]
experimental: [false]
include:
- toolchain: "nightly"
Expand Down Expand Up @@ -308,11 +308,11 @@ jobs:
- build-binary
env:
OLDER_RUST: "1.74" # Rust 1.74 uses rustdoc v27
NEWER_RUST: "nightly" # Rust 1.78-nightly uses rustdoc v28
NEWER_RUST: "nightly" # Rust nightly uses rustdoc v28
steps:
- name: Put env vars in outputs
id: vars
run:
run: |
echo "older-rust=$OLDER_RUST" >> $GITHUB_OUTPUT
echo "newer-rust=$NEWER_RUST" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -346,7 +346,7 @@ jobs:
id: toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: ${{ steps.vars.outputs.OLDER_RUST }}
toolchain: ${{ steps.vars.outputs.older-rust }}
rustflags: ""
cache: false

Expand Down Expand Up @@ -380,12 +380,15 @@ jobs:
- name: Install newer rust
uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: ${{ steps.vars.outputs.NEWER_RUST }}
toolchain: ${{ steps.vars.outputs.newer-rust }}
rustflags: ""
cache: false

- name: Check with older rustdoc version cached
run: |
# Echo commands to make debugging this script easier.
set -x

# Use a separate workspace, to avoid contaminating the cache for Swatinem/rust-cache@v2
cp -R subject subject-new

Expand All @@ -409,7 +412,6 @@ jobs:
export NEW_RUSTDOC_VERSION="$(jq .format_version subject-new/target/semver-checks/cache/registry-libp2p_core-0_37_0.json)"

# Ensure the cached rustdoc versions were indeed different before and after.
set -x
[ "$OLD_RUSTDOC_VERSION" != "$NEW_RUSTDOC_VERSION" ] || exit 1

cross-feature-caching:
Expand Down
Loading