add query override data structures #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
reviewed
Jun 10, 2024
There was a problem hiding this comment.
The data structures seem very sensible and are quite well-documented. Nicely done!
I got a bit tripped up on one of the phrases in the docs. I'm happy to let you take a look and merge immediately after, or even merge now and trust you to make the right tweaks in a subsequent PR if you'd prefer that. Your call!
Co-authored-by: Max Carr <m@mcarr.one>
obi1kenobi
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the new members:
QueryOverrideto configure overridden default values for a lintOverrideMap(type alias) for a mapping of lint ids toQueryOverridestructs.OverrideStack, a stack ofOverrideMaps to store multiple levels of overrides, where items higher in the stack have higher precedence over lower ones when both are set.I kind of struggled in choosing names for these, especially
OverrideMap, so if you have any ideas for that which better represent what it is, please let me know, thanks!