Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add union pub field now doc hidden lint #844

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Add union pub field now doc hidden lint #844

merged 4 commits into from
Jul 31, 2024

Conversation

PedroTurik
Copy link
Contributor

No description provided.

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job! 🚀

src/lints/union_pub_field_now_doc_hidden.ron Outdated Show resolved Hide resolved
@obi1kenobi obi1kenobi enabled auto-merge (squash) July 31, 2024 16:12
@obi1kenobi obi1kenobi merged commit 58d76d6 into obi1kenobi:main Jul 31, 2024
33 checks passed
@obi1kenobi
Copy link
Owner

Great job here! We're now one lint away from completing all of #633. Would you care to write that one last lint so we can close it out?

After that, how would you feel about doing some work on the "opposite end" of the tool — near the CLI side? Suggesting it so that you start to get a more complete picture of cargo-semver-checks as a whole, instead of just working on one corner of it.

@PedroTurik
Copy link
Contributor Author

Great job here! We're now one lint away from completing all of #633. Would you care to write that one last lint so we can close it out?

Absolutely, will give it a look

After that, how would you feel about doing some work on the "opposite end" of the tool — near the CLI side? Suggesting it so that you start to get a more complete picture of cargo-semver-checks as a whole, instead of just working on one corner of it.

Awesome! What do you want me to work on? We can switch to zullip and talk more about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants