Add tests for publish = false workspace members explicitly included with --package
#866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suaviloquence
force-pushed
the
test-workspace-explicitly-publish
branch
from
e8838e6 to
14397e9
Compare
|
Now based on #867, compare link |
suaviloquence
force-pushed
the
test-workspace-explicitly-publish
branch
from
14397e9 to
a0c0a37
Compare
obi1kenobi
reviewed
Aug 16, 2024
Comment on lines
+249
to
+270
| /// Running `cargo semver-checks` on a workspace with a `package = false` member, | ||
| /// explicitly including that member with `--package` and also specifying `--workspace`. | ||
| /// Currently, `--workspace` overrides `--package` and the `publish = false` member is not | ||
| /// semver-checked, and `cargo-semver-checks` silently exits 0. |
There was a problem hiding this comment.
Would you mind opening an issue to make this consistent with just specifying `--package, and linking to it here?
Comment on lines
+260
to
+279
| "--manifest-path", | ||
| "test_crates/manifest_tests/workspace_all_publish_false/new", |
There was a problem hiding this comment.
Another interesting question: what happens if we have --manifest-path test_crates/manifest_tests/workspace_all_publish_false/new/a/Cargo.toml?
Then we explicitly point to the package's manifest, ask for the workspace, then ask for the package itself.
Happy to accept this in a separate PR.
suaviloquence
force-pushed
the
test-workspace-explicitly-publish
branch
from
a0c0a37 to
0f9bcc1
Compare
obi1kenobi
approved these changes
Aug 16, 2024
obi1kenobi
reviewed
Aug 16, 2024
|
Just added a couple of our PR review notes as source code comments, to make our thinking on the subject easier to find in future iterations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests the two behaviors described in #859 (comment).
They are currently not consistent (
--workspace --package xxxdoesn't semver-check and--package xxxdoes).