Fix Python build in CI #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for digging into the issues and making the PR, I appreciate it! 🙏 Out of curiosity, what versions of Python are you using this with? Can I just drop support for <3.11 to simplify the macOS publish flow in the future, or is it still too early for that? |
obi1kenobi
approved these changes
Aug 6, 2024
Comment on lines
+230
to
+231
| # name: wheels-musllinux-${{ matrix.python-version }} | ||
| # path: /io/dist/*.whl |
There was a problem hiding this comment.
Btw if you're familiar with musl, I'd love help in getting this working. I ran into some issues when I last tried it, and set it aside since I didn't have the cycles to finish debugging it.
|
Hey, it worked this time! https://pypi.org/project/trustfall/0.1.7/#files I'm on Python 3.11/3.12 myself. I don't have strong opinions on this, but it does not seem worth it to spend much effort on building wheels for the older versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #650 didn't work.
The problem with the Linux build and Windows build are the breaking changes in #575. From action/upload-artifact's README:
This PR attempts to fix the problem by uploading multiple artifacts and then downloading them all.
The macOS build has two problems:
macos-13runner?Test run here: https://github.com/miikka/trustfall/actions/runs/10270391220 (the final step obviously fails due to lack of permissions)