Skip to content

Commit

Permalink
Merge pull request #2589 from objectcomputing/bugfix-2542/adding-a-su…
Browse files Browse the repository at this point in the history
…pervisor-in-reviews

Bugfix 2542/adding a supervisor in reviews
  • Loading branch information
mkimberlin authored Sep 17, 2024
2 parents 20b0486 + 9196337 commit e4288dd
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion web-ui/src/components/reviews/TeamReviews.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ const TeamReviews = ({ onBack, periodId }) => {
revieweeId: tm.id,
reviewerId: tm.supervisorid,
reviewPeriodId: periodId,
approved: true
approved: false
}));

const res = await resolve({
Expand All @@ -241,8 +241,21 @@ const TeamReviews = ({ onBack, periodId }) => {
if (res.error) return;

setTeamMembers(teamMembers);
addAssignmentForMemberWithNone(teamMembers);
};

const addAssignmentForMemberWithNone = async (members) => {
members.forEach(member => {
const exists = assignments.some(
a => a.revieweeId === member.id
);
if (!!!exists && member.supervisorid) {
const reviewers = [{ id: member.supervisorid }];
updateReviewers(member, reviewers);
}
});
}

const getReviewStatus = useCallback(
teamMemberId => {
let reviewStates = { submitted: false, inProgress: false };
Expand Down

0 comments on commit e4288dd

Please sign in to comment.