Skip to content

Commit

Permalink
Merge pull request #2637 from objectcomputing/bugfix-2632/added-revie…
Browse files Browse the repository at this point in the history
…wee-not-showing-when-they-dont-have-a-supervisor

2024-10-16 - Assign null reviewer if reviewee has no supervisor
  • Loading branch information
mkimberlin authored Oct 16, 2024
2 parents 6022495 + 14c2e4e commit fc5ee05
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion web-ui/src/components/reviews/TeamReviews.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,8 @@ const TeamReviews = ({ onBack, periodId }) => {
// Now that teamMembers has been updated, we need to make sure that the
// assignments reflects the set of team members.
const ids = teamMembers.map(m => m.id);
setAssignments(assignments.filter(a => a.revieweeId && ids.includes(a.revieweeId)));
const newAssignments = assignments.filter(a => a.revieweeId && ids.includes(a.revieweeId));
setAssignments(newAssignments);
};

const addAssignmentForMemberWithNone = async (members) => {
Expand All @@ -268,6 +269,9 @@ const TeamReviews = ({ onBack, periodId }) => {
if (!!!exists && member.supervisorid) {
const reviewers = [{ id: member.supervisorid }];
updateReviewers(member, reviewers);
} else if (!!!exists && !!!member.supervisorid) {
const reviewers = [{ id: null }];
updateReviewers(member, reviewers);
}
});
}
Expand Down

0 comments on commit fc5ee05

Please sign in to comment.