Feature 1557/micronaut 3 upgrade #1717

devaughns · 2022-06-14T17:27:17Z

Solves: #1557
Closes: #1468

Upgrades the entire check-ins application to Micronaut 3.4.3.
Items changed with the upgrade:

reactive items replaced with project reactor references
UserDetails replaced with Authentication
Reference to javax annotations are replaced with jakarta annotations

Implements a background refresh token so the user does not have to refresh the page in order to stay logged in.

Refresh token implementation Initial MN 3 update Removing timeout exception as it no longer exists MailJet Reactor and Authentication RequestLoggingInterceptor reactor and Authentication refactor LocalLoginController Reactor and Authentication refactor CheckinsOpenIdAuthenticationMapper Reactor and Authentication refactor CustomRefreshTokenPersistence Reactor and Authentication refactor LocalUserPasswordAuthProvider Reactor and Authentication refactor CustomJWTClaimsSetGenerator Authentication refactor AgendaItemController Reactor and Authentication refactor CheckinDocumentController Reactor and Authentication refactor CheckInController Reactor and Authentication refactor DemographicsController Reactor and Authentication refactor Mono.just to Mono.fromCallable EmployeeHoursController Reactor and Authentication refactor FeedbackController Reactor and Authentication refactor FeedbackSuggestionsController Reactor and Authentication refactor FeedbackAnswerController Reactor and Authentication refactor CheckServicesController Reactor and Authentication refactor QuestionAndAnswerController Reactor and Authentication refactor FeedbackRequestController Reactor and Authentication refactor FeedbackTemplateController Reactor and Authentication refactor TemplateQuestionController Reactor and Authentication refactor FileController Reactor and Authentication refactor GuildController Reactor and Authentication refactor AnniversaryReportController Reactor and Authentication refactor BirthDayController Reactor and Authentication refactor MemberPhotoController Reactor and Authentication refactor MemberProfileController Reactor and Authentication refactor RetentionReportController Reactor and Authentication refactor MemberSkillController Reactor and Authentication refactor SkillsReportController Reactor and Authentication refactor OpportunitiesController Reactor and Authentication refactor PermissionController Reactor and Authentication refactor PrivateNoteController Reactor and Authentication refactor PulseResponseController Reactor and Authentication refactor QuestionController Reactor and Authentication refactor QuestionCategoryController Reactor and Authentication refactor RoleController Reactor and Authentication refactor RolePermissionController Reactor and Authentication refactor SettingsController Reactor and Authentication refactor CombineSkillController Reactor and Authentication refactor SkillController Reactor and Authentication refactor SurveyController Reactor and Authentication refactor EntityTagController Reactor and Authentication refactor TagController Reactor and Authentication refactor TeamController Reactor and Authentication refactor Updating tests to pass with updated Flyway Fixing tests for LocalLoginController Fixing tests for ActionItemController Fixing tests for AgendaItemController Fixing tests for CheckinDocumentController Fixing tests for CheckInController Fixing tests for CheckinNoteController Manually tested LocalLoginController Fixing tests for DemographicsController Fixing tests for FeedbackController Fixing tests for FeedbackRequestController Fixing tests for FeedbackTemplateController Fixing tests for TemplateQuestionController Fixing tests for GuildController Fixing tests for GuildMemberController Fixing tests for AnniversaryReportController Fixing tests for BirthDayController Fixing tests for MemberProfileController Fixing tests for RetentionReportController Fixing tests for MemberSkillController Fixing tests for OpportunitiesController Fixing tests for PermissionController Fixing tests for PrivateNoteController Fixing tests for PulseResponseController Fixing tests for QuestionCategoryController Fixing tests for QuestionController Fixing tests for RolePermissionController Fixing tests for RoleController Fixing tests for SettingsController Fixing tests for CombineSkillsController Fixing tests for SurveyController Fixing tests for EntityTagController Fixing tests for TagController Fixing tests for TeamMemberController Fixing tests for TeamControllerTest Removing TODOs after manually testing Adding more fields to RefreshToken for more granular control Enabling silent refreshing of an access-token Fixing test

…' into feature-1557/micronaut-3-upgrade # Conflicts: # server/build.gradle # server/src/main/java/com/objectcomputing/checkins/notifications/email/MailJetSender.java # server/src/main/java/com/objectcomputing/checkins/services/agenda_item/AgendaItemController.java # server/src/main/java/com/objectcomputing/checkins/services/feedback_answer/question_and_answer/QuestionAndAnswerServicesImpl.java # server/src/main/java/com/objectcomputing/checkins/services/feedback_template/template_question/TemplateQuestionController.java # server/src/main/java/com/objectcomputing/checkins/services/questions/Question.java

Removing lowered exp time for testing

devaughns · 2022-06-14T20:33:22Z

web-ui/src/api/api.js

+        return axios.get('/oauth/access_token', {
+          baseURL: BASE_API_URL,
+          withCredentials: true,
+          timeout: 30000
+        })
+          .then(() => {
+            // retry original request
+            return myAxios(err.config);
+          })
+          .catch(() => {
+            return Promise.reject(err);


This is the main logic for getting a refresh token. Axios will intercept the HTTP 401 errors and attempt to retrieve an access token with the refresh token stored in the browser's cookies. Upon completion of the refresh token request, the original request will trigger.

devaughns · 2022-06-14T20:37:10Z

server/src/main/resources/db/common/V90__create_refresh_token_table.sql

+    user_name varchar,
+    date_created timestamp,
+    revoked boolean
+);


Adds a persistable refresh token. Included within this table is the revoked field. This is not yet implemented but could be useful in the future to revoke a refresh token if an employee should no longer have access but their browser still has an access token.

devaughns · 2022-06-14T20:37:57Z

server/src/main/resources/application.yml

+          refresh-token:
+            enabled: true
+            path: /oauth/access_token
+            secret: ${ OAUTH_REFRESH_TOKEN_SECRET:'pleaseChangeThisSecretForANewOne' }


Adds an optional secret to be set within the Cloud Run instance.

mkimberlin · 2022-06-16T20:38:42Z

Hey @devaughns any clue on the failing test in this?

devaughns · 2022-06-20T20:56:18Z

There seems to be an issue with using @ColumnTransformer on content in Feedback. It performs as expected with inserts and selects, but it is failing on updates. This seems to be a Micronaut issue. I'll need to hunt down whether it's implemented incorrectly, or if there is a bug in the version of Micronaut we're using.

…eature-1557/micronaut-3-upgrade

paulrdurham and others added 11 commits March 30, 2022 08:55

initial upgrade commit

6869a76

Added @singleton to CustomRefreshTokenPersistence class

4591205

Added debugging LOG.infos to persistance

eb59c61

initial upgrade commit

afdc755

Added @singleton to CustomRefreshTokenPersistence class

cc8709d

Added debugging LOG.infos to persistance

5220ad9

Fixing merge items

72ce355

Update application-local.yml

f70c773

Removing lowered exp time for testing

devaughns commented Jun 14, 2022

View reviewed changes

devaughns requested review from mkimberlin and pieperm June 14, 2022 20:39

devaughns marked this pull request as ready for review June 14, 2022 20:42

mkimberlin added 6 commits June 22, 2022 12:21

Remove feedback service

90dda4a

Remove references to Feedback class and related changes

40a8e80

Fixed migration number

946f0e0

Merge branch 'develop' of github.com:objectcomputing/check-ins into f…

b82897e

…eature-1557/micronaut-3-upgrade

Merge branch 'develop' of github.com:objectcomputing/check-ins into f…

a8fec5c

…eature-1557/micronaut-3-upgrade

Fixed Inject package on test

f1baca8

mkimberlin merged commit ec27c91 into develop Jun 23, 2022

mkimberlin deleted the feature-1557/micronaut-3-upgrade branch June 23, 2022 18:47

pieperm mentioned this pull request Aug 11, 2022

Inform user of session expiration #1923

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature 1557/micronaut 3 upgrade #1717

Feature 1557/micronaut 3 upgrade #1717

devaughns commented Jun 14, 2022 •

edited

Loading

devaughns Jun 14, 2022

devaughns Jun 14, 2022 •

edited

Loading

devaughns Jun 14, 2022

mkimberlin commented Jun 16, 2022

devaughns commented Jun 20, 2022

Feature 1557/micronaut 3 upgrade #1717

Feature 1557/micronaut 3 upgrade #1717

Conversation

devaughns commented Jun 14, 2022 • edited Loading

devaughns Jun 14, 2022

Choose a reason for hiding this comment

devaughns Jun 14, 2022 • edited Loading

Choose a reason for hiding this comment

devaughns Jun 14, 2022

Choose a reason for hiding this comment

mkimberlin commented Jun 16, 2022

devaughns commented Jun 20, 2022

devaughns commented Jun 14, 2022 •

edited

Loading

devaughns Jun 14, 2022 •

edited

Loading