-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swag at permissions changes #2135
Swag at permissions changes #2135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mkimberlin Did you intend to merge this into feature-2064/admin-ui-page? |
@ZacharyKlein I did. The permissions weren't loaded into global state, just local state in the EditPermissionsPage. So, in order to provide the selector method that I promised @S78901, I had to come off of their branch. |
server/src/main/java/com/objectcomputing/checkins/services/permissions/Permission.java
Show resolved
Hide resolved
server/src/main/java/com/objectcomputing/checkins/services/permissions/Permission.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/objectcomputing/checkins/security/permissions/Permissions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Michael! Thanks for adding the finishing touch with the new Java changes
Talked to Syd last night and ended up taking a swag at this while my family was gone and I was bored. 🤣 It ended up coming together pretty quickly. @S78901 had most of it there already, and it was really just a matter of writing a couple of map calls to get it going.
Just in case @S78901 wanted to preserve any of that code, I have left the original page in place and copied it over to PermissionsPage. However, if I didn't forget anything, it could be removed.