Email added/updated guild leaders about their assignment #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/2363-email-guild-leaders
chrismckiernan
changed the title
mvolkmann
approved these changes
Jun 3, 2024
vhscom
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Looks like we're calling an undefined variable when attempting to log which would throw an error in the browser. Our linter doesn't pick up on this currently and because we're not strongly typed it's easy to miss as the type of log is any per static analysis.
…omputing/check-ins into feature/2363-email-guild-leaders
chrismckiernan
force-pushed
the
feature-2363/email-guild-leaders
branch
from
96a81d6
to
128e161
Compare
…omputing/check-ins into feature-2363/email-guild-leaders
|
🎉 Should we close #2363 as completed by this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.