Feature 2596/send email mjml #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ocielliottc
commented
Oct 7, 2024
ocielliottc
commented
- Pulled in mjml4j to implement an MJML email sender.
- Converted all emails sent by the Feedback Request Services to MJML (using provided templates).
- Switched the Pulse Email over to MJML.
- Updated tests.
… be in the designated format. Also, fixed a bug where self-review emails would be sent for non-self-review updates.
… or feedback request.
|
Rather than hardcoding those MJML strings, why don't we load them as resources? Here's an example of what that could look like: https://github.com/ghillert/resource-readable-demo |
ocielliottc
force-pushed
the
feature-2596/send-email-mjml
branch
from
04b1190
to
bd7230c
Compare
thelenw
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
@mkimberlin reworked implementation of key MJML mechanism. @ocielliottc's original upgrades seem sound. Approved.
mkimberlin
approved these changes
Oct 10, 2024
thelenw
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.