-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2596/send email mjml #2617
Conversation
ocielliottc
commented
Oct 7, 2024
- Pulled in mjml4j to implement an MJML email sender.
- Converted all emails sent by the Feedback Request Services to MJML (using provided templates).
- Switched the Pulse Email over to MJML.
- Updated tests.
… be in the designated format. Also, fixed a bug where self-review emails would be sent for non-self-review updates.
… or feedback request.
Rather than hardcoding those MJML strings, why don't we load them as resources? Here's an example of what that could look like: https://github.com/ghillert/resource-readable-demo |
04b1190
to
bd7230c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkimberlin reworked implementation of key MJML mechanism. @ocielliottc's original upgrades seem sound. Approved.