Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kudos Skeleton Size Mismatch #2627

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Kudos Skeleton Size Mismatch #2627

merged 7 commits into from
Oct 9, 2024

Conversation

thelenw
Copy link
Collaborator

@thelenw thelenw commented Oct 9, 2024

Branch

feature-2605/kudos-skeleton-size-mismatch

Updates

  1. Fixed skeleton loader width to match loaded cards on Admin > Manage Kudos

Purpose

Improve UX on all devices, in cases of slow connection.

@thelenw thelenw self-assigned this Oct 9, 2024
@thelenw thelenw mentioned this pull request Oct 9, 2024
Closed
@thelenw
Copy link
Collaborator Author

thelenw commented Oct 9, 2024

This caused a bug on Home where Kudos aren't centered. Working to resolve.

@thelenw thelenw mentioned this pull request Oct 9, 2024
Closed
@thelenw thelenw added enhancement New feature or request web-ui labels Oct 9, 2024
@mkimberlin mkimberlin merged commit 4505118 into develop Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkimberlin mkimberlin mkimberlin approved these changes

Assignees

@thelenw thelenw

Labels
enhancement New feature or request web-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelenw @mkimberlin