Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate rule #435

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Remove duplicate rule #435

merged 2 commits into from
Jul 19, 2024

Conversation

eyihluyc
Copy link
Member

@eyihluyc eyihluyc commented Jul 18, 2024

There were two rules named R_MISS, this PR removes one of them


PR-Codex overview

This PR updates the Yegor YAML file and removes unnecessary lines in a Phi file.

Detailed summary

  • Removed unnecessary lines in int.phi file
  • Updated output in yegor.yaml file

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0crat
Copy link

0crat commented Jul 18, 2024

@eyihluyc It is not a good idea to name Git branches the way you named this one: "fix-r-miss-duplicate". You've earned -10 points for this: -10 as a basis. Next time, better give your branch the same name as the number of the ticket that you are solving. In this case, a perfect name, for example, would be "434".

@fizruk fizruk merged commit be68feb into master Jul 19, 2024
@fizruk fizruk deleted the fix-r-miss-duplicate branch July 19, 2024 03:45
@0crat
Copy link

0crat commented Jul 19, 2024

@eyihluyc Thanks for the contribution! You've earned +20 points for this: +20 as a basis; +5 for 13 hits-of-code; -5 for 1 comments. Please, keep them coming. Your running balance is -10.

@0crat
Copy link

0crat commented Jul 19, 2024

@fizruk Thanks for the review! You've earned +35 points for this: +25 as a basis; +5 for 13 hits-of-code; +5 for 1 comments. Your running balance is -35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants