389 fix sorting in numeric columns #460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces a
ToDataSort
type class and adds data-sort attributes to HTML elements.Detailed summary
ToDataSort
type class for converting data types toInteger
toDataSort
implementations forDouble
,Percent
, andInteger
mkDataSortAttribute
function for creating data-sort attributestoHtmlChange
function to include data-sort attributes based on the valuetoHtmlReportRow
function to includeN/A
fallback values for missing attributes