Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

389 fix sorting in numeric columns #460

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

deemp
Copy link
Member

@deemp deemp commented Jul 30, 2024


PR-Codex overview

This PR introduces a ToDataSort type class and adds data-sort attributes to HTML elements.

Detailed summary

  • Added ToDataSort type class for converting data types to Integer
  • Added toDataSort implementations for Double, Percent, and Integer
  • Added mkDataSortAttribute function for creating data-sort attributes
  • Modified toHtmlChange function to include data-sort attributes based on the value
  • Modified toHtmlReportRow function to include N/A fallback values for missing attributes

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@deemp deemp linked an issue Jul 30, 2024 that may be closed by this pull request
2 tasks
@fizruk fizruk merged commit 968c752 into master Aug 1, 2024
8 checks passed
@fizruk fizruk deleted the 389-fix-sorting-in-numeric-columns branch August 1, 2024 16:06
@0crat
Copy link

0crat commented Aug 1, 2024

@deemp Thanks for the contribution! You've earned +27 points for this: +30 as a basis; +7 for the 71 hits-of-code that you wrote; -10 for too few (0) comments. Please, keep them coming. Your running balance is +73.

@0crat
Copy link

0crat commented Aug 1, 2024

@fizruk Thanks for the review! You've earned +22 points for this: +25 as a basis; +7 for the 71 hits-of-code that you reviewed; -10 for too few (0) comments. Your running balance is +263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix sorting in numeric columns
3 participants