-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
36 Unit tests #461
36 Unit tests #461
Conversation
@Anatolay It is not a good idea to name Git branches the way you named this one: " |
|
||
|
||
%% File generated by the BNF Converter (bnfc 2.9.5). | ||
The Language Syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you change file encoding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change applied automatically when I pulled and built master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diif comparison shows that it only added blank lines, no other changes
|
||
|
||
%% File generated by the BNF Converter (bnfc 2.9.5). | ||
The Language Syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you change file encoding?
} | ||
deriving (Generic, FromJSON, Show) | ||
|
||
newtype RuleTestOption = TakeOne {take_one :: Bool} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should rename TakeOne
to RuleTestOption
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed there could be more options in the future. I can rename for now, though
@Anatolay, it was discussed, but not agreed. |
@Anatolay, it was agreed to write at least 3 tests. |
Let's merge this, and follow up with more unit tests if necessary, in a separate PR. |
@Anatolay Thanks for your review! While we appreciate your effort, reviewing your own contribution isn't recommended. You've earned +5 points: +25 base, -40 for self-review, +20 minimum adjustment. Remember, external reviews often provide valuable insights. Your current balance is +23. Keep up the good work, and consider inviting others to review your future contributions! |
@deemp Hey there! 👋 Great job on the review! You've snagged +42 points for this one: +25 for being an awesome reviewer, +6 for tackling those 340 hits-of-code (that's a lot!), and +11 for your 11 insightful comments. 💬 Your effort really shows, especially since you avoided the -10 point deduction for having less than 6 comments. Keep up the fantastic work! Your running balance is now +130. Remember, the more you contribute, the more you earn. Looking forward to your next review! 🚀 |
Closes #36.
This PR adds:
yegor.yaml
PR-Codex overview
This PR introduces a new
RuleTestOption
type, allowing for test-specific options in the EO Phi rules. It also modifies test cases to include these options for more flexibility.Detailed summary
RuleTestOption
type for test-specific optionsRuleTestOption
for more flexibility