Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R_DOT_ρ #468

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add R_DOT_ρ #468

merged 1 commit into from
Aug 9, 2024

Conversation

eyihluyc
Copy link
Member

@eyihluyc eyihluyc commented Aug 8, 2024

Addresses #448.

Also fixes the ρ and nested dispatches test.

This test is fixed in #449 but the results are different, likely because of the reductions in ρ.

This is a result here (1) and in #449 (2):

1. ⟦ x ↦ ⟦ b ↦ ⟦ c ↦ ξ.ρ ⟧.ρ, ρ ↦ ⟦ a ↦ ⟦ b ↦ ⟦ c ↦ ξ.ρ ⟧.ρ ⟧ ⟧ ⟧, λ ⤍ Package ⟧
2. ⟦ x ↦ ⟦ b ↦ ⟦ c ↦ ξ.ρ ⟧.ρ, ρ ↦ ⟦ a ↦ ⟦ b ↦ ⟦ c ↦ ξ.ρ ⟧.c ⟧.b ⟧ ⟧, λ ⤍ Package ⟧

Turns out (2) can be reduced to (1)


PR-Codex overview

This PR updates dataization and rule definitions in the eo-phi-normalizer module. It modifies dataization output and adds a new rule for accessing ρ-binding.

Detailed summary

  • Updated dataization output in dataization.yaml
  • Added a new rule for accessing ρ-binding in yegor.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@eyihluyc eyihluyc marked this pull request as draft August 8, 2024 05:23
@eyihluyc eyihluyc marked this pull request as ready for review August 8, 2024 05:55
@fizruk fizruk merged commit 520529c into master Aug 9, 2024
8 checks passed
@fizruk fizruk deleted the 488-add-dot-rho branch August 9, 2024 11:10
@0crat
Copy link

0crat commented Aug 10, 2024

@fizruk Hey there! 👋 Great job on the review, you've snagged +5 points! Here's the breakdown: +25 for being the author, but we had to deduct 20 because there weren't any comments this time. Remember, more comments can boost your score – up to 20 points! Your current balance is sitting pretty at +280. Keep up the good work, and don't forget to leave some thoughtful comments next time to maximize your bonus! 💪

@0crat
Copy link

0crat commented Aug 10, 2024

@eyihluyc Thank you for your contribution! Your effort is appreciated, but there's room for improvement. Here's the breakdown: +25 points as a base, -10 for no reviewer comments, and -10 for submitting only 19 hits-of-code (below the 20 minimum). This results in a total of +5 points. Remember, code reviews and meaningful contributions are crucial for our team's success. Keep working on improving both quantity and quality. Your current balance stands at +45. Looking forward to your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants