Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to put \rho to the object after taking \lambda #3790

Closed
maxonfjvipon opened this issue Jan 7, 2025 · 3 comments · Fixed by #3803
Closed

No need to put \rho to the object after taking \lambda #3790

maxonfjvipon opened this issue Jan 7, 2025 · 3 comments · Fixed by #3803
Labels

Comments

@maxonfjvipon
Copy link
Member

Here we're trying to copy and put \rho to the object that we get after executing \lambda. I suggest not to do this because:

  1. all of the objects returned from \lambda already have bound \rho attribute
  2. even if just anonymous abstract object is returned from \lambda - there's no sense to bind its \rho with original atom. It'll just add more unnecessary complexity and confusion.
  3. it'll let us not to create a dozens of unnecessary objects in runtime

@yegor256 WDYT?

@yegor256
Copy link
Member

yegor256 commented Jan 8, 2025

there's no sense to bind its \rho with original atom

@maxonfjvipon why so?

@maxonfjvipon
Copy link
Member Author

@maxonfjvipon I think \rho should refer to the parent object. If object has a parent - it means that parent has an attribute which bound with current abstract object, but \lambda is an asset but not attribute and atom don't have don't have any more attributes (except void ones but they don't require \lambda to execute).

@yegor256
Copy link
Member

yegor256 commented Jan 8, 2025

@maxonfjvipon ok, make sense

@yegor256 yegor256 added the bug label Jan 8, 2025
uchitsa pushed a commit to uchitsa/eo that referenced this issue Jan 8, 2025
uchitsa pushed a commit to uchitsa/eo that referenced this issue Jan 8, 2025
uchitsa pushed a commit to uchitsa/eo that referenced this issue Jan 8, 2025
uchitsa pushed a commit to uchitsa/eo that referenced this issue Jan 8, 2025
uchitsa pushed a commit to uchitsa/eo that referenced this issue Jan 8, 2025
uchitsa pushed a commit to uchitsa/eo that referenced this issue Jan 8, 2025
uchitsa pushed a commit to uchitsa/eo that referenced this issue Jan 8, 2025
…ry#3790/join-shake-optimize

bug(objectionary#3780): join `ShakeMojo` and `OptimizeMojo`
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Jan 10, 2025
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Jan 10, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 10, 2025
bug(#3790): fixed `AtWithRho` performance problems + not set rho to lambda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants