Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#3757): Conservative to-phi conversion #3761

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

maxonfjvipon
Copy link
Member

Closes: #3757

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@yegor256 yegor256 added this pull request to the merge queue Dec 25, 2024
Merged via the queue into objectionary:master with commit b967900 Dec 25, 2024
21 checks passed
@0crat
Copy link

0crat commented Dec 26, 2024

@maxonfjvipon Thanks for the contribution! You've earned +4 points for this: +4 as a basis; -8 for too many hits-of-code (282 >= 200); -4 for very few (1) comments; +12 to give you at least something. Please, keep them coming.

@0crat
Copy link

0crat commented Dec 26, 2024

@yegor256 Thanks for the review! You've earned +4 points for this: +4 as a basis; -10 for very few (1) comments; +10 to give you at least something. Your running balance is -8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

we must always print brackets after attribute name
3 participants