bug(#3481): builds FQN via XSL #3808
Merged
+287
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3481
In this PR I introduced XSL transformation that finds closest objects references and builds FQN, almost the same as
add-refs.xsl
does, but it inserts explicit objects.Consider the next EO from
builds-fnq.yaml
pack:The transformation converts it to the next EO:
As you may see - it adds necessary
$
or^.
objects.When it's used in
TrShaking
- we're not going to needadd-refs.xsl
(which is used a several times) anymore because we're going to have FQN that are not needed be be resolved.UPD:
If future, if the transformation is going to be heavy, it can be easily simplified: instead of inserting objects directly - we can attach some numeric attribute to target object. If attribute value is
0
- it means we should use$
, if it's> 0
then we should insert some^.
objects. How much - attribute value shows