Skip to content

Commit

Permalink
feat(#13): Remove old puzzle
Browse files Browse the repository at this point in the history
  • Loading branch information
volodya-lombrozo committed Aug 8, 2023
1 parent c5547fc commit f5197fe
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/main/java/org/eolang/jeo/BytecodeIR.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* Intermediate representation of a class files which can be optimized from bytecode.
*
* @since 0.1.0
* @todo 13:90min Implement BytecodeIR class.
* @todo #13:90min Implement BytecodeIR class.
* The class should implement IR interface and represent a class file.
* It should be able to read the class file and provide access to its bytecode.
* Also we have to define methods which we need from IR to provide future optimizations.
Expand Down
6 changes: 0 additions & 6 deletions src/main/java/org/eolang/jeo/JeoMojo.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,6 @@
* Goal which touches a timestamp file.
*
* @since 0.1.0
* @todo #9:90min Implement the optimization skeleton.
* The optimization skeleton should be implemented without details. Just a sketch.
* The skeleton should contain the next steps:
* - Transpile all bytecode files to the eolang files (XMIR I guess).
* - Invoke some XMIR optimizations (dummy for now).
* - Transpile all XMIR files back to the bytecode.
*/
@Mojo(name = "optimize", defaultPhase = LifecyclePhase.PROCESS_CLASSES)
public final class JeoMojo extends AbstractMojo {
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/eolang/jeo/Optimization.java
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@
* The entrypoint class for the optimization.
*
* @since 0.1.0
* @todo 13:90min Add unit tests for Optimization class.
* @todo #13:90min Add unit tests for Optimization class.
* The unit tests should cover the next cases:
* - The classes directory is empty.
* - The classes directory does not exist.
* - The classes directory has some clases.
* - The classes directory has some classes and some subdirectories.
* - The classes directory has some classes and some garbage.
* When the unit tests are ready, remove that puzzle.
* @todo 13:90min Implement back transformation to bytecode.
* @todo #13:90min Implement back transformation to bytecode.
* The Optimization class should transform the IRs back to bytecode.
* When the back transformation is ready, remove that puzzle.
* Don't forget to add unit tests for the back transformation.
Expand Down

5 comments on commit f5197fe

@0pdd
Copy link

@0pdd 0pdd commented on f5197fe Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 9-82e8ae6f disappeared from src/main/java/org/eolang/jeo/JeoMojo.java), that's why I closed #13. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link

@0pdd 0pdd commented on f5197fe Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 13-0aa69d09 discovered in src/main/java/org/eolang/jeo/BoostLogged.java) and submitted as #23. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on f5197fe Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 13-934f8528 discovered in src/main/java/org/eolang/jeo/Optimization.java) and submitted as #24. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on f5197fe Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 13-89551792 discovered in src/main/java/org/eolang/jeo/Optimization.java) and submitted as #25. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on f5197fe Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 13-f243b827 discovered in src/main/java/org/eolang/jeo/BytecodeIR.java) and submitted as #26. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.