Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomClassWriter.java:48-52: Disable automatic frame... #528

Closed
0pdd opened this issue Mar 27, 2024 · 3 comments · Fixed by #539
Closed

CustomClassWriter.java:48-52: Disable automatic frame... #528

0pdd opened this issue Mar 27, 2024 · 3 comments · Fixed by #539

Comments

@0pdd
Copy link

0pdd commented Mar 27, 2024

The puzzle 488-6ff6c12e from #488 has to be resolved:

jeo-maven-plugin/src/main/java/org/eolang/jeo/representation/bytecode/CustomClassWriter.java

Lines 48 to 52 in 6d8a626

* @todo #488:90min Disable automatic frame computation in the ClassWriter.
* The ClassWriter is currently configured to automatically compute the stack map frames.
* This is a very expensive operation and it is not necessary for our use case.
* But if we disable it, tests fail.
* We need to investigate why this happens and fix it.

The puzzle was created by @volodya-lombrozo on 27-Mar-24.

Estimate: 90 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Mar 27, 2024
@volodya-lombrozo
feat(#488): use default version if it isn't set at xmir
6d8a626
This was referenced Mar 27, 2024
Closed
Closed
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Apr 3, 2024
@volodya-lombrozo
feat(objectionary#528): add compute frames flag to all ClassWriter im…
c352335 
…plementations
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Apr 3, 2024
@volodya-lombrozo
feat(objectionary#528): suggest ugly solution
4dd3098
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Apr 3, 2024
@volodya-lombrozo
feat(objectionary#528): remove the puzzle for objectionary#528 issue
1e4442f
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Apr 3, 2024
@volodya-lombrozo
feat(objectionary#528): remove redundant code
64f5331
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Apr 3, 2024
@volodya-lombrozo
feat(objectionary#528): move all writers under CustomClassWriter class
92758fa
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Apr 3, 2024
@volodya-lombrozo
feat(objectionary#528): fix all linter suggestions
1324d4e
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Apr 3, 2024
@volodya-lombrozo
feat(objectionary#528): add one more puzzle
a61520a
@volodya-lombrozo volodya-lombrozo mentioned this issue Apr 3, 2024
Merged
0pdd referenced this issue Apr 3, 2024
@rultor
Merge branch '__rultor'
e462828
@0pdd 0pdd mentioned this issue Apr 3, 2024
Closed
@0pdd
Copy link
Author

0pdd commented Apr 3, 2024

@0pdd the puzzle #540 is still not solved.

@0pdd
Copy link
Author

0pdd commented Oct 10, 2024

@0pdd 3 puzzles #750, #751, #752 are still not solved; solved: #540.

@0pdd
Copy link
Author

0pdd commented Oct 11, 2024

@0pdd the puzzle #750 is still not solved; solved: #540, #751, #752.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Smart Max Stack, Max Locals, and Frames Computation volodya-lombrozo/jeo-maven-plugin
1 participant
@0pdd