Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml:280-283: Upgrade qulice-maven-plugin version.... #650

Closed
0pdd opened this issue Jul 31, 2024 · 7 comments · Fixed by #652
Closed

pom.xml:280-283: Upgrade qulice-maven-plugin version.... #650

0pdd opened this issue Jul 31, 2024 · 7 comments · Fixed by #652
Assignees
Labels
good first issue Good for newcomers

Comments

@0pdd
Copy link

0pdd commented Jul 31, 2024

The puzzle 648-2bb14378 from #648 has to be resolved:

jeo-maven-plugin/pom.xml

Lines 280 to 283 in 7b792bd

@todo #648:30min Upgrade qulice-maven-plugin version.
Currently we can't do it because qulice fails on ubuntu 20.04 and Java 8.
We should find the original reason why this happens and upgrade the version.
Up to 0.23.0, or latest.

The puzzle was created by @volodya-lombrozo on 31-Jul-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@h1alexbel
Copy link
Contributor

@volodya-lombrozo I can take it

@h1alexbel
Copy link
Contributor

@volodya-lombrozo

Here is what happens on Java 8 with qulice-maven-plugin=0.23.0:

java.lang.UnsupportedClassVersionError: com/puppycrawl/tools/checkstyle/api/CheckstyleException has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

This means a version mismatch: runtime is of version 52.0=Java1.8, while class was compiled by the version of 55 =Java 11. Check this answer on Stack Overflow. This is because qulice didn't support Java 1.8. Can we get rid of Java 1.8 here too, and build our code on Java 11+?

@volodya-lombrozo
Copy link
Member

@h1alexbel Suddenly, we can't get rid of Java 8. Actually we started this project with Java 11 and then realised that we need Java 8 as well. So, what I suggest is to configure pom.xml the way to use different versions of qulice based on the current Java version.

Here is how you can achieve this.

What do you think?

@h1alexbel
Copy link
Contributor

@volodya-lombrozo got it, I will try

h1alexbel added a commit to h1alexbel/jeo-maven-plugin that referenced this issue Aug 1, 2024
h1alexbel added a commit to h1alexbel/jeo-maven-plugin that referenced this issue Aug 1, 2024
h1alexbel added a commit to h1alexbel/jeo-maven-plugin that referenced this issue Aug 1, 2024
h1alexbel added a commit to h1alexbel/jeo-maven-plugin that referenced this issue Aug 1, 2024
h1alexbel added a commit to h1alexbel/jeo-maven-plugin that referenced this issue Aug 1, 2024
h1alexbel added a commit to h1alexbel/jeo-maven-plugin that referenced this issue Aug 2, 2024
h1alexbel added a commit to h1alexbel/jeo-maven-plugin that referenced this issue Aug 2, 2024
@0crat
Copy link

0crat commented Aug 2, 2024

@0pdd Thanks for submitting this ticket! However, as you see, it was not accepted by the team, which is sad. You've earned -20 points. By reporting bugs or suggesting enhacements, you help our project improve its quality. Please, don't be discouraged. Instead, try to be more careful next time, and do not hesitate to report bugs.

@0pdd
Copy link
Author

0pdd commented Aug 2, 2024

@0pdd Thanks for submitting this ticket! However, as you see, it was not accepted by the team, which...

I see you're talking to me, but I can't reply since I'm not a chat bot.

1 similar comment
@0pdd
Copy link
Author

0pdd commented Aug 2, 2024

@0pdd Thanks for submitting this ticket! However, as you see, it was not accepted by the team, which...

I see you're talking to me, but I can't reply since I'm not a chat bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants