Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#91): refactor method names and modifiers #137

Merged

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Oct 6, 2023

Create separate data objects for method modifiers in XMIR representation.

Closes: #91


History:


PR-Codex overview

This PR focuses on handling method parameters in the DirectivesMethod class. It includes changes to handle method parameters and generate correct XML representation of the class.

Detailed summary

  • Added handling of method parameters in DirectivesMethod class
  • Updated XML representation of methods to include method parameters
  • Removed unused imports

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Oct 6, 2023

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit f633426 into objectionary:master Oct 6, 2023
8 checks passed
@rultor
Copy link
Contributor

rultor commented Oct 6, 2023

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BytecodeRepresentation.java:130-133: Handle method...
3 participants