feat(#701): Refactor Annotation Properties #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of annotation values
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here |
@volodya-lombrozo Done! FYI, the full log is here (took me 33min) |
|
@volodya-lombrozo Hey there! 👋 Thanks for your contribution! While it's impressive you wrote 1808 hits-of-code, that's actually a bit too much for our bonus system. 😅 We couldn't award points for the code review or comments since there weren't any. But don't worry, we've still got you covered with 4 points! Remember, quality over quantity is key. Keep the contributions coming, but maybe aim for smaller, more focused chunks next time. Your balance is now at +100. Looking forward to your next contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I significantly simplified the work with annotation values.
Now we don't have ugly enums and for each case we have a separate small object that is resposible
only for its own area.
I removed
DirectivesAnnotationPropertyandBytecodeAnnotationPropertyclasses since they violate code standards.Closes: #701.
History:
PR-Codex overview
This PR focuses on refactoring the
BytecodeAnnotationPropertyclass and related components in theorg.eolang.jeo.representationpackage. It introduces new classes for different annotation value types and updates existing logic to utilize these new structures.Detailed summary
BytecodeAnnotationPropertyandDirectivesAnnotationPropertyclasses.BytecodePlainAnnotationValue,BytecodeArrayAnnotationValue,BytecodeEnumAnnotationValue, andBytecodeAnnotationAnnotationValue.XmlAnnotationPropertyto return new bytecode types.annotationPropertymethod to use new classes.DirectivesPlainAnnotationValue,DirectivesEnumAnnotationValue,DirectivesArrayAnnotationValue, andDirectivesAnnotationAnnotationValue.