feat(#520): Remove Redundant Classes Related To Data Transformation #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion test now works fine
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here |
@volodya-lombrozo Done! FYI, the full log is here (took me 36min) |
|
@volodya-lombrozo Thanks for your contribution! You've earned +4 points: +4 base, -8 for exceeding 200 hits-of-code (1018), -16 for surpassing 800 hits-of-code, -16 for no code review, -4 for only 2 comments, +44 adjustment. While the volume is impressive, remember our policy emphasizes quality and review. Aim for smaller, focused contributions with thorough reviews. Your balance is now +96. Keep improving and contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I remove such classes like
HexDataandHexStrin. Their functionality is placed to appropriate classes.Related to #520.
History:
PR-Codex overview
This PR focuses on refactoring the
HexDatarepresentation to useXmlValuefor handling hexadecimal data, along with the removal of obsolete classes and tests related toHexData. It also improves type handling and introduces new functionality for data encoding and decoding.Detailed summary
HexData.java,HexDataTest.java,XmlBytes.java, andHexString.java.XmlInstruction.javato useXmlValuefor integer and boolean conversions.UnrecognizedOpcodeclass to remove thepublicmodifier.DirectivesValueto handle various data types and improve hex conversion.DataTypeto remove primitive class references and streamline type handling.