-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#520): Remove Redundant Classes Related To Data Transformation #742
feat(#520): Remove Redundant Classes Related To Data Transformation #742
Conversation
…tion test now works fine
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here |
@volodya-lombrozo Done! FYI, the full log is here (took me 36min) |
@volodya-lombrozo Thanks for your contribution! You've earned +4 points: +4 base, -8 for exceeding 200 hits-of-code (1018), -16 for surpassing 800 hits-of-code, -16 for no code review, -4 for only 2 comments, +44 adjustment. While the volume is impressive, remember our policy emphasizes quality and review. Aim for smaller, focused contributions with thorough reviews. Your balance is now +96. Keep improving and contributing! |
In this PR I remove such classes like
HexData
andHexStrin
. Their functionality is placed to appropriate classes.Related to #520.
History:
PR-Codex overview
This PR focuses on refactoring the
HexData
representation to useXmlValue
for handling hexadecimal data, along with the removal of obsolete classes and tests related toHexData
. It also improves type handling and introduces new functionality for data encoding and decoding.Detailed summary
HexData.java
,HexDataTest.java
,XmlBytes.java
, andHexString.java
.XmlInstruction.java
to useXmlValue
for integer and boolean conversions.UnrecognizedOpcode
class to remove thepublic
modifier.DirectivesValue
to handle various data types and improve hex conversion.DataType
to remove primitive class references and streamline type handling.