feat(#752): Refactor MaxStack
and MaxLocals
classes
#754
+289
−243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I significantly simplified
MaxStack
andMaxLocals
classes.Closes: #752, #751
PR-Codex overview
This PR focuses on refactoring the
MaxStack
andMaxLocals
classes to improve readability and reduce cognitive complexity. It replaces the existing logic with a more streamlined approach using theInstructionsFlow
class for better data-flow analysis.Detailed summary
instructions
type inMaxStack
fromInstructionsFlow
toList<? extends BytecodeEntry>
.value()
method inMaxStack
to use a newInstructionsFlow
implementation.Stack
class for managing stack values inMaxStack
.MaxLocals
to useInstructionsFlow
and simplified variable handling.