feat(#762): Improve Logging and Exception Handling #763
+121
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 Could you have a look at this PR, please? |
|
@rultor merge |
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
@volodya-lombrozo Done! FYI, the full log is here (took me 7min). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I imporved logging for dissasembled and assembled files to the following:
Moreover, I added several checks to catch exceptions carefully (and added context to them.)
Related to #762.
History:
lang.IndexOutOfBoundsExceptioninorg.eolang.jeo.representation.xmir.XmlAnnotation.child#762): add children size check before parsing an annotationlang.IndexOutOfBoundsExceptioninorg.eolang.jeo.representation.xmir.XmlAnnotation.child#762): add size for assembled and disassembled fileslang.IndexOutOfBoundsExceptioninorg.eolang.jeo.representation.xmir.XmlAnnotation.child#762): add one more unit test for XmlAnnotationlang.IndexOutOfBoundsExceptioninorg.eolang.jeo.representation.xmir.XmlAnnotation.child#762): fix all the code offenceslang.IndexOutOfBoundsExceptioninorg.eolang.jeo.representation.xmir.XmlAnnotation.child#762): add one more catch clausePR-Codex overview
This PR introduces a
size()method to various classes, improves error handling inXmlAnnotation, and updates logging messages in theAssemblerandDisassemblerclasses to include size information.Detailed summary
size()method toRepresentationandXmirRepresentationclasses.size()method inBytecodeRepresentationto return input length.AssemblerandDisassemblerto include size.XmlAnnotationto throwParsingExceptionon failures.XmlAnnotationTestfor broken XML scenarios.