Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#765): Unroll Annotations Correctly #766

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Oct 16, 2024

Update the unrolling train according with the following suggestions:
#765 (comment)

Related to #765.


PR-Codex overview

This PR introduces new features and improvements, including the addition of @Parameter annotations, updates to transformation XSL files, and the inclusion of copyright notices. It enhances the code structure and clarifies the handling of specific XML transformations.

Detailed summary

  • Added @Parameter annotation in App.java and Parameter.java.
  • Marked main method as @Deprecated in App.java.
  • Updated CanonicalXmir.java to use Shift type with TrClasspath and TrDefault.
  • Added remove-cuts.xsl and add-cuts.xsl with MIT License.
  • Modified vars-float-down.xsl to improve template matching logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Could you take a look, please?

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo looks good, should work

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Oct 16, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 76f6c00 into objectionary:master Oct 16, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Oct 16, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 7min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants