Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#779): Add j$ Prefix For Packages #781

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Oct 21, 2024

In this PR I added j$ prefix for package names.
Moreover, I slightly modified the prefix adding strategy: we used to add the prefix only to the last element in the name, now we add the prefix for all the elements.

Was: org/eolang/j$EoParser
Become: j$org/j$eolang/j$EoParser

Related to #779.


PR-Codex overview

This PR focuses on enhancing the handling of prefixed names in the Eolang representation, particularly in encoding and decoding processes, and updating relevant tests to reflect these changes.

Detailed summary

  • Updated retrievesName method to change expected name format.
  • Modified BachedTranslator application to improve readability.
  • Adjusted encodesName method to use PrefixedName for encoding.
  • Enhanced HasClass to encode package names using PrefixedName.
  • Updated DirectivesMetas to utilize prefixed package names.
  • Added new methods in PrefixedName for encoding and decoding.
  • Improved handling of prefixed strings in decode and added a cut method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you have a look, please? These changes should solve the problem with package names.

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Oct 21, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 3d70f23 into objectionary:master Oct 21, 2024
11 checks passed
@rultor
Copy link
Contributor

rultor commented Oct 21, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 9min).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants