Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#65): get lints for gh-pages in runtime #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Marat-Tim
Copy link

adds all motives of active lints to the Github pages branch

@Marat-Tim
Copy link
Author

I understand that there are many errors here, but I wanted to do something so that you could specifically point them out to me

@Marat-Tim Marat-Tim force-pushed the 65 branch 4 times, most recently from 65fd9ec to db25c7c Compare December 11, 2024 18:35
@yegor256
Copy link
Member

@Marat-Tim looks like a good start! Now, please, try to make all build jobs pass.

@Marat-Tim Marat-Tim force-pushed the 65 branch 3 times, most recently from 6497a58 to 63cb8b0 Compare January 29, 2025 15:16
@Marat-Tim
Copy link
Author

@yegor256 I'm ready for my code to be destroyed)

I have a few questions

  1. Do we collect the jar file somewhere and can we download it from there? Then from pom.xml it will be possible to remove the build plugin in jar

  2. I assume that the PrintAllLines class needs to be moved to a separate project. If I create a project in the repository, won't it break some kind of pipeline? And again, how can I connect the latest version of the main project to subproject?

  3. On behalf of whom to make a push request to the gh-pages branch? Now I've done it on my own login

  4. How good is the idea of JavaLint? After all, if I wrap it at the wrong moment (for example, after wrapping it in Unlint), the name will be lost. Or you'll have to recursively get the decorated object, which sounds pretty crooked

@Marat-Tim Marat-Tim changed the title feat(#65): mvp feat(#65): get lints for gh-pages in runtime Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants