feat(#322): unlint-non-existing-defect lint
#339
Conversation
|
@maxonfjvipon please check |
|
@maxonfjvipon would like to hear your feedback on this |
|
@maxonfjvipon reminder |
|
|
||
| /** | ||
| * Lints. | ||
| * @since 0.0.0 |
There was a problem hiding this comment.
@h1alexbel let's put a valid minor version here
| String.format( | ||
| "program/metas/meta[head='unlint' and tail='%s']/@line", unlint | ||
| ) | ||
| ).map(xnav -> xnav.text().get()) |
There was a problem hiding this comment.
@h1alexbel I think something's wrong with indentation here
There was a problem hiding this comment.
@maxonfjvipon qulice complains otherwise about cascade indentation
| unlint -> | ||
| xml.path( | ||
| String.format( | ||
| "program/metas/meta[head='unlint' and tail='%s']/@line", unlint |
There was a problem hiding this comment.
@h1alexbel let's try to use Xnav here instead of XPath
There was a problem hiding this comment.
@maxonfjvipon actually we are using Xnav here:
final Xnav xml = new Xnav(xmir.inner());
xml.path(..);Or you meant we should use xml.element() instead?
There was a problem hiding this comment.
@h1alexbel sorry, didn't notice it. Then it's okay
|
@maxonfjvipon updated. Take a look, please |
|
@maxonfjvipon reminder |
|
@yegor256 take a look, please |
|
@h1alexbel thanks! |
In this PR I've added new lint:
unlint-non-existing-defect, that issues defects with warning severity, in case of usage of+unlintmeta to suppress non-existing defects.closes #322
History:
+unlintmay only suppress an existing warning #322): unlint-non-existing-defect+unlintmay only suppress an existing warning #322): clean for qulice