-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#343): POC: show defect context if @line
attributes are empty
#349
base: master
Are you sure you want to change the base?
Conversation
@volodya-lombrozo take a look, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel Thank you for the contribution! Just one small comment.
Additionally, maybe we can add a puzzle that would suggest to fix the issue with large context values? What do you think?
|
||
/** | ||
* Defect with context. | ||
* @since 0.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel [NIT] Can we put exact numbers here 0.1.0
or 0.0.40
?
@volodya-lombrozo for lage-context values, we already show only first 300 chars from the context string. In
|
@h1alexbel Could you add the test for this case please? |
@volodya-lombrozo updated. Take a look, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel Looks good to me, thank you!
@yegor256 take a look, please, what do you think about such feature? |
@yegor256 reminder |
In this PR I've implemented Proof Of Concept of printing defect's context, if inspected XMIR doesn't have
@line
attributes inside.see #343
History:
@line
Attribute is Absent #343): print first N chars@line
Attribute is Absent #343): poc