Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#59): get URL instead of File, EO-parser with compile scope #61

Merged
merged 17 commits into from
Nov 29, 2024

Conversation

@h1alexbel
Copy link
Contributor Author

h1alexbel commented Nov 28, 2024

@yegor256 take a look, please. I've reproduced the problem with invoker setup. See the logs here: https://github.com/objectionary/lints/actions/runs/12073961454/job/33671084222?pr=61. I've added puzzle to resolve this issue and enable integration pack in invoker.

@h1alexbel h1alexbel changed the title fix(#59): invoker setup to reproduce XSL FileNotFoundException fix(#59): get URL instead of File, EO-parser with compile scope Nov 28, 2024
@h1alexbel
Copy link
Contributor Author

@yegor256 take a look, please

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<stack-size>256M</stack-size>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel this is not necessary, since you don't use this variable in the POM

* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
final class LintsIt {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel you can delete this file, the test will pass too

@yegor256
Copy link
Member

@h1alexbel good one! Here is a perfect example of how we modify just one line in production code, but add 500 lines to tests :) See my comments above, small ones.

@h1alexbel
Copy link
Contributor Author

@yegor256 updated pull request. Take a look again, please

@h1alexbel h1alexbel requested a review from yegor256 November 29, 2024 07:11
@yegor256 yegor256 merged commit 6dc7b24 into objectionary:master Nov 29, 2024
12 checks passed
@yegor256
Copy link
Member

@h1alexbel thanks!

@h1alexbel h1alexbel deleted the 59 branch November 29, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants