-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#59): get URL instead of File, EO-parser with compile scope #61
Conversation
|
@yegor256 take a look, please |
src/it/lints-it/pom.xml
Outdated
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
<maven.compiler.source>1.8</maven.compiler.source> | ||
<maven.compiler.target>1.8</maven.compiler.target> | ||
<stack-size>256M</stack-size> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel this is not necessary, since you don't use this variable in the POM
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
final class LintsIt {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel you can delete this file, the test will pass too
@h1alexbel good one! Here is a perfect example of how we modify just one line in production code, but add 500 lines to tests :) See my comments above, small ones. |
@yegor256 updated pull request. Take a look again, please |
@h1alexbel thanks! |
In this pull request I reproduced and fixed the problem with accessing XSL lint file outside of the lints Java package on macOS.
ref #59
History: