Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#268): remove the crutch related to InnerClasses attributes #301

Merged

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Jun 7, 2024

Remove unnecessary crutch that changed InnerClass objects to avoid printing them to PHI excpressions.
Now jeo-maven-plugin disassembles them correctly and we don't need this crutch.

Closes: #268.


PR-Codex overview

This PR removes a temporary fix related to InnerClass in the FormattingDecompiler.java file.

Detailed summary

  • Removed the crutch related to InnerClass
  • Updated the format method to remove the name attribute from InnerClass elements

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jun 7, 2024

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 5252996 into objectionary:master Jun 7, 2024
8 checks passed
@rultor
Copy link
Contributor

rultor commented Jun 7, 2024

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 7min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormattingDecompiler.java:123-127: Remove the crutch...
3 participants