Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2e12 #2

Merged
merged 2 commits into from
Nov 27, 2012
Merged

M2e12 #2

merged 2 commits into from
Nov 27, 2012

Conversation

nmishkin
Copy link

@nmishkin nmishkin commented Nov 8, 2012

Here are my changes to make the connectors work with m2e 1.2. Everything builds but I am able to test only the jflex connector. I can't get the tests to pass, but it looks like that has something to do with environment requirements of the tests. If you want me to "try harder" at that, let me know, but I suspect you could just do it all more quickly than I can.

@rkrzewski
Copy link
Member

I'm seeing test failures in your branch as well. I'm looking into it rigtht now.

@nmishkin
Copy link
Author

Did you make any progress looking into the test failures?

@rkrzewski
Copy link
Member

I spent some time on that today, and to my suprise it turned out that deleting target directories here and there allowed to bulid the whole thing cleanly (on your branch). It appears that I had some stale build output from eclipse peppered with UnresolvedCompilationProblem exceptions in integration test projects. It was not being cleaned out by a mvn clean at the top level, because IT projects are not submodules of the corresponding test projects.

If you are on linux, you can run find -name target | xargs rm -rf at the project root directory and see if it helps.

rkrzewski added a commit that referenced this pull request Nov 27, 2012
Support for m2e 1.2.0 + project version bump.
@rkrzewski rkrzewski merged commit 5318c6c into objectledge:master Nov 27, 2012
@rkrzewski
Copy link
Member

I've done some rudimentary testing on my workspaces that use the connector and all seems fine.
I've pushed the binary release to http://objectledge.github.com/maven-extensions/connectors/updates/development

@nmishkin
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants