fix gradle setup #227
fix gradle setup #227
Conversation
|
I'm following this from some discussion with @SaeedZhiany on a different issue, and I don't see how this gets rid of the gradle version in the module android/build.gradle, it seems like it just moves it to .kts files. How does this actually help solve the related issue? I would love the ability to have no gradle version specified in my module's android/build.gradle so the app drove the overall version |
|
I'll try to elaborate on the change, sorry for late reply. android folder is used in RN app as a module, so having Android Gradle Plugin in it causes version conflict related issues. So it removed Android Gradle Plugin from android/build.gradle file. but to build and test the module code, we need a project to wrap it, so I created a build.gradle.kts in its parent to make it project, which includes android module. So in Android Studio, you no longer open android folder as project, but it's parent. |
|
also moved wrapper to parent directory or project. |
|
Ah interesting - so think of this as active listening where I check my understanding - for this to really solve the problem it would need to be similar to the ext{} block of versions, where modules would all need to adopt this style where as a module maintainer you sort of used a new / available "namespace" / gradle project space for module work, and doing so it means there is no longer gradle version stuff in a place where the react-native project build sees it. If I got that correct I could see this working, but I could also see the transition taking some time to propagate out to the module ecosystem... |
|
@mikehardy yep, it'll take some time to propagate |
|
@vonovak please review 👍 |
|
@vonovak As a fellow library maintainer I have a hard time keeping up with all the current styles an fashion in the react-native world, but I have to say after reviewing all the related discussions on this one with @dulmandakh and @SaeedZhiany, this actually looks like the right way to go (and the way I will go with my modules), even though I was a little skeptical at first. At the very least, it moves you up from gradle 1.x :-) |
| // This source code is licensed under the MIT license found in the | ||
| // LICENSE file in the root directory of this source tree. | ||
|
|
||
| buildscript { |
There was a problem hiding this comment.
This is the cool part - because the build script is in kotlin (which Android Studio recognizes just fine) but is in the module root, you can build your module just fine for testing - with specific versions - but when people import it into their work project, your project definition doesn't really exist. They import it using their project's gradle versions.
|
Wish I could have more time for OSS now to dive more into this; thanks for the PR! This is not a breaking change, correct? |
|
yep, not a breaking change. |
|
Is it possible to revert these changes and use the @friederbluemle's idea in this comment? |
|
Yes, it should be possible: #263 |
Importing Android Gradle Plugin in android/build.gradle is causing issues if version mismatch with root project. This PR tried to fix gradle setup, and moving most of the setup from android to project root.