Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] add a fixed container so the searchbar are always on reach #1121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[docs] add a fixed container so the searchbar are always on reach #1121

wants to merge 1 commit into from

Conversation

WeslleyNasRocha
Copy link

@WeslleyNasRocha WeslleyNasRocha commented Jan 29, 2020 •
edited
Loading

image

@szholdiyarov
Copy link
Contributor

hey @WeslleyNasRocha

Thanks for your contribution 👍🏼

what are the screen dimensions of the display on that screenshot?

@WeslleyNasRocha
Copy link
Author

I guess 1920x1080

@WeslleyNasRocha
Copy link
Author

But what i was trying to show with it is that the section header it sticks on below the nav header

@szholdiyarov
Copy link
Contributor

szholdiyarov commented Feb 18, 2020 •
edited
Loading

I guess 1920x1080

I just tried to reproduce the issue, but no luck. So to be honest I do not see any points considering merge of this PR?

@WeslleyNasRocha
Copy link
Author

I guess 1920x1080

I just tried to reproduce the issue, but no luck. So to be honest I do not see any points considering merge of this PR?

The issue is, when im mid page i dont know what icon collection im in, and have to scroll the page up to see or even search
image

mine PR keeps the header on screen, so the user can search easily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szholdiyarov szholdiyarov Awaiting requested review from szholdiyarov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeslleyNasRocha @szholdiyarov