-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support web-platform (Icon & Icon.Button) #133
Conversation
How can we make this support custom fonts as well? |
What do you mean by that? |
@IjzerenHein: |
Ah I see, I'll have a look when I have some more time 👍 |
I've started a project which uses |
@ptmt: I'm not going to merge this PR because I'm not entirely happy with how the CSS is inserted. However the latest version does fix the |
Sure, thanks! |
@oblador how do you want it inserted? This package would be big for the React Native Web community which more and more developers are veering toward daily. |
@IjzerenHein I used the code from your pull request and the font isn't installed in the In case anyone else is interested, I've fallin back to manually inserting a font bundle in the head from a CDN and creating my own In addition, with webpack it's challenging to get the font served. On top of these issues, React Storybook doesn't seem to give you control of the HTML file that has the bundle script in it, so you can't easily put a cdn font url there. It seems there's a lot to think about to get this nicely working for react-native-web across a variety of scenarios. I'm sure someone with more webpack experience would have an easier time serving the font file from |
Not sure what you mean, this package works just fine on the web. There's even a web project in this repo and steps in documentation. There might be ways of making it slightly easier, but this is not it. |
This adds support for
react-native-web
.