feat: add support for lucide icons #1630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @oblador! Please what would it take to get this merged? |
|
Hi @rexfordessilfie. We are currently focussing on a major new release (check https://github.com/oblador/react-native-vector-icons/tree/monorepo). This should happen in the next 2 weeks. I'll then be able to take a look at this. We'll need to do a new PR to support the new approach to per package fonts, but that should be pretty straight forward for this font. |
|
That looks great and thanks for the response @johnf! Looking forward to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for Lucide icons.
I was working on an Expo project, and wanted to use Lucide icons and followed the trail here to issue #1470. I hope I have implemented this in the right way, and that it will be useful to library users!
Thank you,
Rex
Screenshots
Showcasing icons in
IconExplorerexamplelucide-icons-demo.webm