Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android font copying #1648

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix android font copying #1648

wants to merge 1 commit into from

Conversation

johnf
Copy link
Collaborator

@johnf johnf commented Aug 25, 2024

No description provided.

@johnf
Copy link
Collaborator Author

johnf commented Sep 15, 2024

@oblador Can you also merge this and release but in a new version after the fontawesome fix
We've had lots of movement around this code not working for different folks almost every new RN version
This PR replaces it with what's in the monorepo code

def generateAssetsTask = tasks.findByName("generate${targetName}Assets")
generateAssetsTask.dependsOn(fontCopyTask)
}
variant.preBuildProvider.configure { it.dependsOn(fontCopyTask) }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this and having the preBuild task depend on it? When you tried this out, did you clear gradle cache in-between, because when I tried it didn't work properly.

@Luminted
Copy link

In the meanwhile this change is merged, for any developer coming across this issue:
A termporary and clean way to get around this error is to disable the problematic linting task in gradle. For example:
gradlew clean build -x lintAnalyze

@yasirbam
Copy link

In the meanwhile this change is merged, for any developer coming across this issue: A termporary and clean way to get around this error is to disable the problematic linting task in gradle. For example: gradlew clean build -x lintAnalyze

The workaround is not working for me, I am getting this error;

Task 'lintAnalyze' is ambiguous in root project 'ShifaMobile' and its subprojects. Candidates are: 'lintAnalyzeDebug', 'lintAnalyzeDebugAndroidTest', 'lintAnalyzeDebugUnitTest', 'lintAnalyzeRelease', 'lintAnalyzeReleaseUnitTest', 'lintVitalAnalyzeDebug', 'lintVitalAnalyzeRelease'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants