Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Mac OS X #173

Closed
wants to merge 4 commits into from
Closed

Port to Mac OS X #173

wants to merge 4 commits into from

Conversation

ptmt
Copy link

@ptmt ptmt commented Apr 16, 2016

Introduce support for a new target. I'm using this project so often, in fact, it's my "default-project" which I always install. Would be awesome to have support for Cocoa framework. I added a new target and some preprocessor macros for handle the differences. Need to test it more, hope nothing breaks.

Also, breaking change inside to get rid of the warnings which comes with latest RN release candidate.

var React = require('react')
var ReactNative = require('react-native')

screenshot 2016-04-16 17 29 35

@oblador
Copy link
Owner

oblador commented Apr 16, 2016

Absolute killer! I'll test this out once I get some more time on my hands, meanwhile would it make sense to include a tiny example?

@oblador
Copy link
Owner

oblador commented May 9, 2016

2.0.0 adds basic OSX support complete with example project, but had trouble getting the getImageSource implementation you wrote to actually work. Care to look into it in a new PR?

Also I'm not happy with how react-native-desktop naming conflicts with react-native in Packager but maybe unavoidable.

@ptmt
Copy link
Author

ptmt commented May 9, 2016

Thank you, I'll take a look. And yes, you should add rn-cli.config.js for RN blacklisting each other to the root to avoid the conflicts (the same for windows). Will add a note about this, I guess.

@oblador
Copy link
Owner

oblador commented May 9, 2016

Btw, have you looked at how react-native-web solves the issue of requiring a specialized copy of react-native?

@ptmt
Copy link
Author

ptmt commented May 9, 2016

If I understood you correctly, AFAIK, they use webpack, so this is easy for them since it has aliases ('react-native': 'react-native-web')

@oblador
Copy link
Owner

oblador commented May 9, 2016

@ptmt: Ah, well there's babel-plugin-module-alias for babel, but maybe it conflicts with packager.

@jeduan
Copy link

jeduan commented May 10, 2016

This change is needed to avoid warnings on >= 0.25. Any chance we can merge that? I can send a new PR if needed.

@oblador
Copy link
Owner

oblador commented May 10, 2016

@jeduan: It's released in 2.0.0.

@jeduan
Copy link

jeduan commented May 10, 2016

Ah, I didn't catch it. Thanks!

@oblador oblador changed the title Port to Mac OS and RN 0.24+ Port to Mac OS X May 13, 2016
@ptmt
Copy link
Author

ptmt commented Feb 3, 2017

Oh, didn't know it still exists here. Let's keep it low profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants