Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For web! #415

Merged
merged 6 commits into from
Jul 30, 2017
Merged

For web! #415

merged 6 commits into from
Jul 30, 2017

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Feb 24, 2017

Needed compiled source.

  • Included babel-cli
  • Included yarn
  • Included babel-preset-react-native
  • Included build-web script to compile the code

Now I can use for react-native-web (anyone can use this too for RN I believe). This should be the "true" main in package.json right? We might want to move all these files into an actual lib (built files) and src (original files) folders.

import Icon from 'react-native-vector-icons/Web/FontAwesome'

@oblador
Copy link
Owner

oblador commented Mar 27, 2017

Awesome, this might actually be useful for all platforms since it helps with jest testing too. Let me think about this for a few moments!

@scf4
Copy link

scf4 commented May 2, 2017

@oblador any update on this?

@joncursi
Copy link

joncursi commented Jun 6, 2017

Bump! 😄

@oblador oblador merged commit 24291a0 into oblador:master Jul 30, 2017
@oblador
Copy link
Owner

oblador commented Jul 30, 2017

A thousand times sorry that this has taken such a long time getting merged. Don't want to break existing installations so for now I'll publish the transpiled versions under dist (instead of web) so your imports will be import Icon from 'react-native-vector-icons/dist/FontAwesome'.

One could move the source files (or omit them entirely as they kind of are build artifacts too), but I see it as useful to keep them there so that people can see which files that are requirable directly in the repo without having to read the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants