Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sorting in cynic-parser pretty printing #1038

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

obmarg
Copy link
Owner

@obmarg obmarg commented Sep 25, 2024

Why are we making this change?

I'm writing some tests that compare the output of the same schema but from two different sources. I'm using cynic-parsers pretty printing to get consistent formatting of these two schemas. But the order that the definitions are output in between the two schemas does not match.

What effects does this change have?

Adds an optional setting to the cynic-parser formatting that causes the definitions & fields of the schema to be sorted prior to output.

@obmarg obmarg changed the title feat: optional sorting in cynic-parser pretty printing feat: sorting in cynic-parser pretty printing Sep 25, 2024
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for cynic-querygen-web canceled.

Name Link
🔨 Latest commit 48efdaf
🔍 Latest deploy log https://app.netlify.com/sites/cynic-querygen-web/deploys/66f4234903107d0007212d50

@obmarg obmarg force-pushed the obmarg/vnnnpkmmoxkt branch 2 times, most recently from d4d9d7e to fa27c20 Compare September 25, 2024 14:05
@obmarg obmarg merged commit 1ace812 into main Sep 25, 2024
6 checks passed
@obmarg obmarg deleted the obmarg/vnnnpkmmoxkt branch September 25, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant