Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better type kind mismatch errors #889

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

obmarg
Copy link
Owner

@obmarg obmarg commented Apr 6, 2024

A user ran into this particular error message and it wasn't clear to them what their mistake was. This change hopefully makes things clearer.

@obmarg obmarg enabled auto-merge (squash) April 6, 2024 16:25
Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for cynic-querygen-web canceled.

Name Link
🔨 Latest commit 738b52d
🔍 Latest deploy log https://app.netlify.com/sites/cynic-querygen-web/deploys/6611777a89bcf100085d1af5

@obmarg obmarg merged commit 21cec74 into main Apr 6, 2024
6 checks passed
@obmarg obmarg deleted the obmarg/push-wvkynkmwkvou branch April 6, 2024 16:28
@cynic-releaser cynic-releaser bot mentioned this pull request Apr 6, 2024
obmarg added a commit that referenced this pull request Apr 12, 2024
## 🤖 New release
* `cynic`: 3.5.1 -> 3.5.2 (✓ API compatible changes)
* `cynic-proc-macros`: 3.5.1 -> 3.5.2
* `cynic-codegen`: 3.5.1 -> 3.5.2 (✓ API compatible changes)
* `cynic-parser`: 0.2.1 -> 0.2.2 (✓ API compatible changes)
* `cynic-cli`: 3.5.1 -> 3.5.2
* `cynic-introspection`: 3.5.1 -> 3.5.2
* `cynic-querygen`: 3.5.1 -> 3.5.2

<details><summary><i><b>Changelog</b></i></summary><p>

## `cynic`
<blockquote>

## [3.5.2](v3.5.1...v3.5.2) -
2024-04-12

### Fixed
- specifically use serde::Serialize in Scalar derive
([#909](#909))
- merge problems in cynic-codegen
([#896](#896))
- better type kind mismatch errors
([#889](#889))

### Other
- unintentional recursion panic
([#890](#890))
- remove last criterion benchmark
([#898](#898))
- Update cynic-codegen to use cynic-parser
([#824](#824))
- concurrency on release task & remove a TODO
([#884](#884))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Signed-off-by: cynic-releaser[bot] <166170668+cynic-releaser[bot]@users.noreply.github.com>
Co-authored-by: cynic-releaser[bot] <166170668+cynic-releaser[bot]@users.noreply.github.com>
Co-authored-by: Graeme Coupar <graeme@turbofish.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant