Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: directive support on fields #900

Merged
merged 13 commits into from
Dec 31, 2024
Merged

feat: directive support on fields #900

merged 13 commits into from
Dec 31, 2024

Conversation

obmarg
Copy link
Owner

@obmarg obmarg commented Apr 7, 2024

For a long time cynic has not supported any directives. This PR adds support for the built in skip & include directives, and also any other field directives that don't require explicit client support.

Fixes #645

Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for cynic-querygen-web canceled.

Name Link
🔨 Latest commit a58b525
🔍 Latest deploy log https://app.netlify.com/sites/cynic-querygen-web/deploys/6773fdb70a013b000876a0b9

@obmarg obmarg added this to the 4.0.0 milestone Apr 7, 2024
@obmarg obmarg force-pushed the obmarg/push-rlwlzxuwqsvo branch 2 times, most recently from 03853ee to b621eb8 Compare April 9, 2024 21:13
@obmarg obmarg force-pushed the obmarg/push-rlwlzxuwqsvo branch from b621eb8 to ca5b5e6 Compare June 8, 2024 16:53
@obmarg obmarg force-pushed the obmarg/push-rlwlzxuwqsvo branch from ca5b5e6 to b62ae0a Compare June 8, 2024 16:58
@obmarg obmarg marked this pull request as ready for review June 8, 2024 17:01
@obmarg obmarg changed the title feat: support skip & include on fields feat: directive support Dec 31, 2024
@obmarg obmarg changed the title feat: directive support feat: directive support on fields Dec 31, 2024
@obmarg obmarg merged commit 49d41d5 into main Dec 31, 2024
6 checks passed
@obmarg obmarg deleted the obmarg/push-rlwlzxuwqsvo branch December 31, 2024 14:26
@cynic-releaser cynic-releaser bot mentioned this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directive support
1 participant