Create synonym pipeline #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rays22
reviewed
Jul 15, 2022
src/templates/synonyms.tsv
Outdated
| @@ -0,0 +1,5 @@ | |||
| Ontology ID Label Exact synonym Close Synonym Related synonym Broad synonym Narrow synonym Contributor | |||
| ID A oboInOwl:hasExactSynonym SPLIT=| A oboInOwl:hasCloseSynonym SPLIT=| A oboInOwl:hasRelatedSynonym SPLIT=| A oboInOwl:hasBroadSynonym SPLIT=| A oboInOwl:hasNarrowSynonym SPLIT=| AI dc:contributor SPLIT=| | |||
| http://purl.obolibrary.org/obo/OBA_VT0010023 forelimb length forearm length ulna length https://orcid.org/0000-0003-2699-3066 | |||
There was a problem hiding this comment.
'ulna length' does not look right as a narrow synonym.
rays22
reviewed
Jul 15, 2022
src/templates/synonyms.tsv
Outdated
| ID A oboInOwl:hasExactSynonym SPLIT=| A oboInOwl:hasCloseSynonym SPLIT=| A oboInOwl:hasRelatedSynonym SPLIT=| A oboInOwl:hasBroadSynonym SPLIT=| A oboInOwl:hasNarrowSynonym SPLIT=| AI dc:contributor SPLIT=| | ||
| http://purl.obolibrary.org/obo/OBA_VT0010023 forelimb length forearm length ulna length https://orcid.org/0000-0003-2699-3066 | ||
| http://purl.obolibrary.org/obo/OBA_VT1000062 chest circumference chest girth|girth of chest https://orcid.org/0000-0003-2699-3066 | ||
| http://purl.obolibrary.org/obo/OBA_VT1000425 skin mass body mass https://orcid.org/0000-0003-2699-3066 |
There was a problem hiding this comment.
'body mass' seems unnecessary as a synonym here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@megbalk This is how it would look like
@rays22 simply review the synonyms.tsv file that @megbalk provided. You can merge this PR if you think her synonyms are good choices!