Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SSSOM mapping files #208

Merged
merged 6 commits into from
Jul 7, 2023
Merged

Update SSSOM mapping files #208

merged 6 commits into from
Jul 7, 2023

Conversation

rays22
Copy link
Contributor

@rays22 rays22 commented Feb 3, 2023

Following SOP here.

@rays22 rays22 self-assigned this Feb 3, 2023
@matentzn
Copy link
Contributor

matentzn commented Feb 3, 2023

Why is the diff so large?

@rays22
Copy link
Contributor Author

rays22 commented Feb 3, 2023

Why is the diff so large?

I have updated some term labels and fixed an incorrect mapping.

@rays22
Copy link
Contributor Author

rays22 commented Feb 3, 2023

Why is the diff so large?

It looks like that somebody has also updated the match_type on every line of the vt sssom table.

matentzn
matentzn requested changes Feb 5, 2023
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reduce the diff, the mapping_justification should be always semapv:ManualMappingCuration and I am worried that I made some changes to these files without updating them on Google Docs (during the paper writing)

@rays22 rays22 mentioned this pull request Feb 8, 2023
Open
@rays22
Copy link
Contributor Author

rays22 commented Jul 6, 2023

Please reduce the diff, the mapping_justification should be always semapv:ManualMappingCuration and I am worried that I made some changes to these files without updating them on Google Docs (during the paper writing)

I have reduced the size of the diff by using semapv:ManualMappingCuration for mapping_justification.

@rays22 rays22 requested a review from matentzn July 6, 2023 13:57
matentzn
matentzn approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rays22 rays22 merged commit b60fb39 into master Jul 7, 2023
@rays22 rays22 deleted the 2023-02-03sssom_update branch July 7, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

@ar-ibrahim ar-ibrahim Awaiting requested review from ar-ibrahim

Assignees

@rays22 rays22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rays22 @matentzn